Skip to content

[SDK-327] Make getEmbeddedMessage return consistent #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lposen merged 3 commits into from
Jan 26, 2026
Merged

[SDK-327] Make getEmbeddedMessage return consistent #808

lposen merged 3 commits into from
Jan 26, 2026
+32 −39

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Jan 23, 2026 •
edited by atlassian bot
Loading

🔹 JIRA Ticket(s) if any

✏️ Description

Make the return for getEmbeddedMessages consistent when no apis are given

Test

  • Run android app
  • Log in
  • Click on 'Embedded' tab
  • Without putting any placement ids in, click "Get messages for placement ids" -- All embedded messages should be returned
  • Add a placement id
  • Click "Get messages for placement ids" -- Only embedded messages for that placement id should be returned

@qltysh
Copy link

qltysh bot commented Jan 23, 2026

1 new issue

Tool Category Rule Count
qlty Structure Function with high complexity (count = 14): getEmbeddedMessages 1

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

Lines Statements Branches Functions
Coverage: 63%
 63.07% (398/631) 40.07% (103/257) 61.5% (139/226)

@qltysh
Copy link

qltysh bot commented Jan 23, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

🚦 See full report on Qlty Cloud »

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Ayyanchira
Ayyanchira reviewed Jan 26, 2026
View reviewed changes
example/src/components/Embedded/Embedded.tsx
<Text style={styles.warningText}>
⚠️ Embedded messaging is disabled. Please enable it in your Iterable config.
⚠️ Embedded messaging is disabled. Please enable it in your Iterable
config.
Copy link
Member

@Ayyanchira Ayyanchira Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this warning going to be displayed?

Copy link
Member

@Ayyanchira Ayyanchira Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, its a part of example. So should be good

Ayyanchira
Ayyanchira approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

example/src/components/Embedded/Embedded.tsx
<Text style={styles.warningText}>
⚠️ Embedded messaging is disabled. Please enable it in your Iterable config.
⚠️ Embedded messaging is disabled. Please enable it in your Iterable
config.
Copy link
Member

@Ayyanchira Ayyanchira Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, its a part of example. So should be good

joaodordio
joaodordio approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@joaodordio joaodordio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lposen lposen merged commit b5c8048 into loren/embedded/master Jan 26, 2026
8 checks passed
@lposen lposen deleted the feature/SDK-327-getmessages-is-inconsistent-in-ios-vs-android branch January 26, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaodordio joaodordio joaodordio approved these changes

@Ayyanchira Ayyanchira Ayyanchira approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lposen @joaodordio @Ayyanchira